Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ResourceList for resource requests #49320

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Nov 21, 2024

After we removed the legacy view for resource requests from Connect we can also get rid of resource lists that are no longer used.

An added benefit is that we're closer to removing teleport imports from shared. Also, we can significantly clean up the code in the new request view in teleport.e (https://github.com/gravitational/teleport.e/pull/5552)

@gzdunek gzdunek added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Nov 21, 2024
@github-actions github-actions bot requested review from avatus and kiosion November 21, 2024 13:05
@gzdunek gzdunek requested review from ravicious and removed request for kiosion November 21, 2024 13:09
Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😌 🧹

@gzdunek gzdunek added this pull request to the merge queue Dec 2, 2024
Merged via the queue into master with commit 431a6ae Dec 2, 2024
39 checks passed
@gzdunek gzdunek deleted the gzdunek/remove-request-tables branch December 2, 2024 13:42
@public-teleport-github-review-bot

@gzdunek See the table below for backport results.

Branch Result
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants