introduce webclient.ReusableClient #49296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
force-pushed
the
hugo/reusable-webproxy-client
branch
from
241395c to
d7ac4e2
Compare
vapopov
approved these changes
Nov 22, 2024
timothyb89
approved these changes
Nov 23, 2024
public-teleport-github-review-bot
bot
removed request for
sclevine and
kiosion
hugoShaka
added
the
no-changelog
|
@hugoShaka See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a reusable webclient for kube-agent-updater consumption.
As described in RFD-184, the updaters should now obtain update instructions by hitting
/find.The kube agent updater is a long-running updater and checks the proxy endpoint frequently. To avoid creating a new HTTP client every minute, this PR extracts a reusable web client, offering the same
Find(),Ping(), andGetMOTD()functions than the webproxy package.Goal (internal): https://github.com/gravitational/cloud/issues/10289