Support custom GOBIN in integrations/terraform/Makefile #49259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
hugoShaka,
marcoandredinis and
tigrato
kopiczko
added
the
no-changelog
marcoandredinis
approved these changes
Nov 20, 2024
tigrato
approved these changes
Nov 20, 2024
public-teleport-github-review-bot
bot
removed the request for review
from hugoShaka
kopiczko
deleted the
kopiczko/support-custom-gobin-for-make-integrations-terraform-docs
branch
hugoShaka
reviewed
Nov 20, 2024
| @echo "protoc-gen-terraform $(PROTOC_GEN_TERRAFORM_VERSION) is not installed. Please, refer to README.md for installation instructions." | ||
| @echo "protoc-gen-terraform $(PROTOC_GEN_TERRAFORM_VERSION) is not installed. Please, see https://github.com/gravitational/protoc-gen-terraform for installation instructions." |
There was a problem hiding this comment.
README.md currently contains the correct installation instructions with the right version, why this change?
There was a problem hiding this comment.
Sorry, I missed this was the README.md in ./integrations/terraform directory. I looked into the top level one and couldn't find anything.
kopiczko
added a commit
that referenced
this pull request
Nov 20, 2024
See the discussion #49259 (comment)
kopiczko
added a commit
that referenced
this pull request
Nov 20, 2024
See the discussion #49259 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from #49256
Also related gravitational/protoc-gen-terraform#45