-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add owner property to TrustedDevices type #48408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the owner property to our TrustedDevices type to support adding owner to our device trust table in `e` Adding as optional for now to not break `e` and will change after the `e` changes are in.
avatus
added
do-not-merge
no-changelog
Indicates that a PR does not require a changelog entry
and removed
do-not-merge
labels
Nov 4, 2024
This pull request is automatically being deployed by Amplify Hosting (learn more). |
zmb3
approved these changes
Nov 4, 2024
kimlisa
approved these changes
Nov 5, 2024
public-teleport-github-review-bot
bot
removed the request for review
from rudream
November 5, 2024 00:24
I'll wait to backport (the whole feature) until 17 is out, unless told otherwise |
avatus
added a commit
that referenced
this pull request
Nov 8, 2024
This adds the owner property to our TrustedDevices type to support adding owner to our device trust table in `e`
avatus
added a commit
that referenced
this pull request
Nov 8, 2024
This adds the owner property to our TrustedDevices type to support adding owner to our device trust table in `e`
avatus
added a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the owner property to our TrustedDevices type to support adding owner to our device trust table in
e
Adding as optional for now to not break
e
and will change after thee
changes are in.