Improve 'Please run' messages in the CI #48365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
added
the
no-changelog
hugoShaka
changed the title
codingllama
reviewed
Nov 4, 2024
| @@ -72,6 +72,9 @@ help: ## Display this help. | |||
|
|
|||
| ##@ Development | |||
|
|
|||
| .PHONY: crd ## Single command to generate anything CRD-related (manifests and docs) | |||
| crd: crdgen crd-docs | |||
There was a problem hiding this comment.
Oh, nice.
Please backport this so workflows don't change between branches.
There was a problem hiding this comment.
👍 will backport the PR to every env
codingllama
reviewed
Nov 4, 2024
Co-authored-by: Alan Parra <[email protected]>
codingllama
approved these changes
Nov 4, 2024
| @@ -72,6 +72,9 @@ help: ## Display this help. | |||
|
|
|||
| ##@ Development | |||
|
|
|||
| .PHONY: crd ## Single command to generate anything CRD-related (manifests and docs) | |||
| crd: crdgen crd-docs | |||
Co-authored-by: Alan Parra <[email protected]>
Co-authored-by: Alan Parra <[email protected]>
tigrato
approved these changes
Nov 4, 2024
public-teleport-github-review-bot
bot
removed request for
marcoandredinis and
kimlisa
|
@hugoShaka See the table below for backport results.
|
hugoShaka
added a commit
that referenced
this pull request
Nov 4, 2024
* Improve 'Please run error' * add missing file * fix script * Apply suggestions from code review Co-authored-by: Alan Parra <[email protected]> * address alan's feedback * Update Makefile Co-authored-by: Alan Parra <[email protected]> * Update build.assets/please-run.sh Co-authored-by: Alan Parra <[email protected]> --------- Co-authored-by: Alan Parra <[email protected]>
hugoShaka
added a commit
that referenced
this pull request
Nov 4, 2024
* Improve 'Please run error' * add missing file * fix script * Apply suggestions from code review Co-authored-by: Alan Parra <[email protected]> * address alan's feedback * Update Makefile Co-authored-by: Alan Parra <[email protected]> * Update build.assets/please-run.sh Co-authored-by: Alan Parra <[email protected]> --------- Co-authored-by: Alan Parra <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
* Improve 'Please run error' * add missing file * fix script * Apply suggestions from code review * address alan's feedback * Update Makefile * Update build.assets/please-run.sh --------- Co-authored-by: Alan Parra <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
* Improve 'Please run error' * add missing file * fix script * Apply suggestions from code review * address alan's feedback * Update Makefile * Update build.assets/please-run.sh --------- Co-authored-by: Alan Parra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quality of life changes: Teleport devs kept missing the "please run X" messages hidden in the action logs.
This PR adds a small helper that:
This does not cover the Helm reference yet because the diff mechanism is a bit different. I might do more of this in the future if people think this helps (e.g. the license error).
What the error message looks like in the PR:
Example of collapsed logs in GHA:
Demo PR