Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exempt dependabot from the changelog workflow #48289

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

codingllama
Copy link
Contributor

The changelog workflow fails because the -reviewers flag is empty. I think that was always the case, but now that the workflow is required this blocks all dependabot PRs.

Example failure:

Run cd .github/shared-workflows/bot && go run main.go -workflow=changelog -token="***" -reviewers=""

2024/11/01 13:42:03 Failed to parse flags: 
ERROR REPORT:
Original Error: *trace.BadParameterError reviewers required for assign and check
Stack Trace:
	/home/runner/work/teleport/teleport/.github/shared-workflows/bot/main.go:141 main.parseFlags
	/home/runner/work/teleport/teleport/.github/shared-workflows/bot/main.go:37 main.main
	/opt/hostedtoolcache/go/1.23.2/x[6](https://github.com/gravitational/teleport/actions/runs/11627067334/job/32388964174?pr=48261#step:4:7)4/src/runtime/proc.go:272 runtime.main
	/opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1[7](https://github.com/gravitational/teleport/actions/runs/11627067334/job/32388964174?pr=48261#step:4:8)00 runtime.goexit
User Message: reviewers required for assign and check.
exit status 1
Error: Process completed with exit code 1.

Reference on shared-workflows:

@codingllama
Copy link
Contributor Author

It's debatable whether this is the best solution, but it's likely the faster and I just want to get the bots unblocked.

@rosstimothy rosstimothy added the no-changelog Indicates that a PR does not require a changelog entry label Nov 1, 2024
@codingllama
Copy link
Contributor Author

@codingllama codingllama enabled auto-merge November 1, 2024 14:04
@codingllama codingllama added this pull request to the merge queue Nov 1, 2024
Merged via the queue into master with commit 264d70c Nov 1, 2024
41 of 42 checks passed
@codingllama codingllama deleted the codingllama/dependabot-changelog branch November 1, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants