Add proto definitions and plugin spec Microsoft Teams no code integration #46640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
reviewed
Oct 1, 2024
EdwardDowling
force-pushed
the
edwarddowling/msteams-one-click
branch
2 times, most recently
from
8dcb5ce to
00b1b65
Compare
github-actions
bot
requested review from
flyinghermit,
hugoShaka,
marcoandredinis and
ryanclark
hugoShaka
reviewed
Oct 8, 2024
hugoShaka
reviewed
Oct 9, 2024
r0mant
reviewed
Oct 16, 2024
The standard for the other plugins has been that the access monitoring rules replace existing recipients and are not additive. We could change that here if you think it makes more sense, it would mean that it would have different behavior to the other plugins unless we are willing to make changes to the behavior of all of them |
r0mant
approved these changes
Oct 21, 2024
|
@hugoShaka @zmb3 can you take another look at this when you get a chance? |
zmb3
approved these changes
Oct 22, 2024
EdwardDowling
force-pushed
the
edwarddowling/msteams-one-click
branch
2 times, most recently
from
55b579f to
20a91b8
Compare
|
@hugoShaka Can you take another look at this once you get a chance? |
hugoShaka
requested changes
Oct 28, 2024
hugoShaka
reviewed
Oct 28, 2024
hugoShaka
reviewed
Oct 28, 2024
EdwardDowling
force-pushed
the
edwarddowling/msteams-one-click
branch
from
20a91b8 to
aa46746
Compare
EdwardDowling
force-pushed
the
edwarddowling/msteams-one-click
branch
from
5d0f966 to
82a3c42
Compare
EdwardDowling
force-pushed
the
edwarddowling/msteams-one-click
branch
from
108eb27 to
9ec83ae
Compare
hugoShaka
approved these changes
Nov 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
…tion (#46640) * Add proto definitions for MsTeams no code integration * Add access monitoring rule and hosted support to msteams plugin * Fix linting * Fix go sum mismatch caused by msteams dependency * Fix linting in access monitoring rules
EdwardDowling
added a commit
that referenced
this pull request
Nov 7, 2024
…tion (#46640) * Add proto definitions for MsTeams no code integration
EdwardDowling
added a commit
that referenced
this pull request
Nov 8, 2024
…tion (#46640) * Add proto definitions for MsTeams no code integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24495
Requires 5032
Requires #47638
Adds definitions required for MsTeams no code integration.
changelog: Add no-code enrollment for Microsoft Teams plugin.