Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 1.7 version #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Archanciel
Copy link

I copied over the 1.6 version I forked from the content of the mod_insertarticle_v1.7_j2.5_3.0.zip and pushed the 1.7 version with no modification from my part. I am now going to add my improvements to the module.

@graredcr
Copy link
Owner

Thank's, I don't know, how work the github. How do i can accept your changes for my Fork? You want?

@Archanciel
Copy link
Author

I will send you a pull request again, since I did finish my modifications.
You just have to go on with thec pull, which will integrate my additions
nicely on your version. The few commits I did are fully commented. You can
also see the differences for each file on GitHub, as expected with a
version control tool.

Here, you find a good info on pull request:
https://help.github.com/articles/using-pull-requests

I would suggest investing some time in learning how to use git since this
is THE src control tool, much better than CVS or Subbversion,

This is an excellent resource for learning: http://www.gitguys.com/topics/
This once too is very good: http://www.gitguys.com/topics/

Best,
Jean-Pierre

          JP Schnyder    senior software engineer    Switzerland

  plusconscient.net propose des centaines d'enregistrements audio
   sur des sujets liés aux grandes problématiques de notre époque

2013/2/14 Cristian Grañó [email protected]

Thank's, I don't know, how work the github. How do i can accept your
changes for my Fork? You want?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-13553014.

@graredcr
Copy link
Owner

Perfect!!! And thanks!!!

I read and learning for use it.

Cristian

2013/2/14 Archanciel [email protected]

I will send you a pull request again, since I did finish my modifications.
You just have to go on with thec pull, which will integrate my additions
nicely on your version. The few commits I did are fully commented. You can
also see the differences for each file on GitHub, as expected with a
version control tool.

Here, you find a good info on pull request:
https://help.github.com/articles/using-pull-requests

I would suggest investing some time in learning how to use git since this
is THE src control tool, much better than CVS or Subbversion,

This is an excellent resource for learning: http://www.gitguys.com/topics/
This once too is very good: http://www.gitguys.com/topics/

Best,
Jean-Pierre

JP Schnyder senior software engineer Switzerland

plusconscient.net propose des centaines d'enregistrements audio
sur des sujets liés aux grandes problématiques de notre époque

2013/2/14 Cristian Grañó [email protected]

Thank's, I don't know, how work the github. How do i can accept your
changes for my Fork? You want?


Reply to this email directly or view it on GitHub<
https://github.com/graredcr/insertbyid/pull/1#issuecomment-13553014>.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-13576512.

@Archanciel
Copy link
Author

I thought I could send you a new pull request, but GitHub won't let me send
you a new pull request before you handled the one I sent you. But I think
that when you accept my pull revquest, this will integrate ALL my modifs.
But no worries: I did tag the upgrade to 1.7 and you will have control on
everything !

          JP Schnyder    senior software engineer    Switzerland


  plusconscient.net propose des centaines d'enregistrements audio
   sur des sujets liés aux grandes problématiques de notre époque

2013/2/14 Jean-Pierre Schnyder [email protected]

I will send you a pull request again, since I did finish my modifications.
You just have to go on with thec pull, which will integrate my additions
nicely on your version. The few commits I did are fully commented. You can
also see the differences for each file on GitHub, as expected with a
version control tool.

Here, you find a good info on pull request:
https://help.github.com/articles/using-pull-requests

I would suggest investing some time in learning how to use git since this
is THE src control tool, much better than CVS or Subbversion,

This is an excellent resource for learning: http://www.gitguys.com/topics/
This once too is very good: http://www.gitguys.com/topics/

Best,
Jean-Pierre

          JP Schnyder    senior software engineer    Switzerland

  plusconscient.net propose des centaines d'enregistrements audio
   sur des sujets liés aux grandes problématiques de notre époque

2013/2/14 Cristian Grañó [email protected]

Thank's, I don't know, how work the github. How do i can accept your
changes for my Fork? You want?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-13553014.

@graredcr graredcr closed this Mar 20, 2014
@graredcr graredcr reopened this Mar 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants