Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extmark-based placeholder for text inputs #7

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

willothy
Copy link
Collaborator

@willothy willothy commented Mar 27, 2024

(reopened from #5, accidentally opened that from the main branch of my fork)

Adds support for a placeholder in text inputs using inline virtual text.

@willothy willothy force-pushed the input-placeholder branch from b309951 to 9f3cc06 Compare March 28, 2024 23:42
@willothy willothy marked this pull request as ready for review March 28, 2024 23:42
@mobily mobily added the feature label Mar 31, 2024
@willothy willothy force-pushed the input-placeholder branch 2 times, most recently from 1734ce8 to d12e3e8 Compare April 1, 2024 17:53
@willothy willothy force-pushed the input-placeholder branch from d12e3e8 to 2d8ec98 Compare April 1, 2024 17:54
Copy link
Contributor

@mobily mobily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thank you! ❤️

@mobily mobily merged commit 67b38d3 into grapp-dev:main Apr 1, 2024
2 checks passed
@willothy
Copy link
Collaborator Author

willothy commented Apr 1, 2024

Awesome! Now everything's in that I am using locally haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants