Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.7 #1543

Merged
merged 3 commits into from
May 16, 2024
Merged

Remove Python 3.7 #1543

merged 3 commits into from
May 16, 2024

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented May 14, 2024

Remove Python 3.6 and 3.7 as they are EOL. pytest is failing on Python 3.12, and Python 3.7 is blocker for pytest upgrade to latest version.

Python 3.6 was removed from CI in #1507.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (5fb7b54) to head (2951fef).

❗ Current head 2951fef differs from pull request most recent head 324ca87. Consider uploading reports for the commit 324ca87 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1543   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files          51       51           
  Lines        1755     1755           
=======================================
  Hits         1685     1685           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dulmandakh dulmandakh changed the title CI: add Python 3.12 CI: remove Python 3.7 May 14, 2024
@dulmandakh
Copy link
Contributor Author

I have no idea where 3.7 job is coming from 🤷‍♂️

@dulmandakh dulmandakh mentioned this pull request May 15, 2024
@dulmandakh
Copy link
Contributor Author

@erikwrede please review and merge, if its good

@dulmandakh dulmandakh changed the title CI: remove Python 3.7 Remove Python 3.7 May 15, 2024
@syrusakbary syrusakbary merged commit 5db1af0 into graphql-python:master May 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants