-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GraphiQL Explorer; fix headers property #1174
Conversation
@@ -286,7 +275,7 @@ | |||
onEditQuery: onEditQuery, | |||
onEditVariables: onEditVariables, | |||
onEditOperationName: onEditOperationName, | |||
headerEditorEnabled: @Model.HeaderEditorEnabled, | |||
isHeadersEditorEnabled: @Model.HeaderEditorEnabled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HeaderEditorEnabled
property was ineffective because the react property name was incorrect. This change fixes the bug.
/// </summary> | ||
[Obsolete("This property has no effect and will be removed in a future version.")] | ||
public bool ExplorerExtensionEnabled { get; set; } = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was no code tied to this property within the entire codebase. So it could not be disabled.
<script | ||
src="https://unpkg.com/[email protected]/graphiqlWithExtensions.min.js" | ||
integrity="sha384-TqI6gT2PjmSrnEOTvGHLad1U4Vm5VoyzMmcKK0C/PLCWTnwPyXhCJY6NYhC/tp19" | ||
crossorigin="anonymous" | ||
></script> | ||
<link | ||
rel="stylesheet" | ||
href="https://unpkg.com/[email protected]/graphiqlWithExtensions.css" | ||
integrity="sha384-GBqwox+q8UtVEyBLBKloN5QDlBDsQnuoSUfMeJH1ZtDiCrrk103D7Bg/WjIvl4ya" | ||
crossorigin="anonymous" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
graphiql-with-extensions
was last released 5 years ago, and its package.json
indicates that it was designed for version 0.14.2 of GraphiQL. It does not appear to be compatible with GraphiQL 3.x and so I removed it. GraphiQL does have a docs explorer built-in, although it does not have the checkbox functionality that the graphiql-explorer
extension did.
See:
Changes:
ExplorerExtensionEnabled
(which did nothing) as obsoleteHeaderEditorEnabled
so it works properly