-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor indexer management API layer #859
base: main
Are you sure you want to change the base?
Conversation
not used anywhere
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
12241928 | Triggered | Generic High Entropy Secret | 430cdeb | network-configs/config.yaml | View secret |
12251296 | Triggered | Generic High Entropy Secret | 430cdeb | network-configs/config.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Summary
Rework the
indexer-common
GraphQL API layer to utilize GraphQL Codegen Server preset with GraphQL Yoga.Background
When I was working on #858 I noticed that to create new resolver we update the SDL and then manually type out everything. When I was trying to write unit tests there was some bug which was causing my writes to be not written to DB. The setup is uncommon and debugging was just painful. This PR attempts to do something to reduce the pain
What does this PR change?
This is first attempt to improve DX and make contributions easier. There is a lot more we can clean and improve but this already a large PR so should scope more time for follow-ups.