Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update common-ts and other dependencies #779

Merged
merged 7 commits into from
Sep 21, 2023

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented Sep 18, 2023

Fixes: #775

TO DO

  • update common-ts to version 2.0.5 (after it is released)
  • Identify and remove the “hacky” stuff in the findEvent function
  • Tests are failing due to a type error in common-ts v2.0.5
  • Ensure everything works afterward:
    • Refactor indexer tests to reflect contract changes. (not needed)
    • Manually test an indexing rule being picked up
    • Manually test allocations being opened/closed/renewed

@tilacog tilacog force-pushed the tiago/allocaitons-cli-fixes branch from d81e489 to 7a07a62 Compare September 18, 2023 20:40
@tilacog tilacog linked an issue Sep 18, 2023 that may be closed by this pull request
@tilacog tilacog force-pushed the tiago/allocaitons-cli-fixes branch from 9a59c34 to b12f4ec Compare September 18, 2023 22:27
@tilacog tilacog requested a review from fordN September 18, 2023 22:32
@tilacog tilacog marked this pull request as ready for review September 18, 2023 22:32
@tilacog tilacog marked this pull request as draft September 19, 2023 01:15
@tilacog tilacog added this to the v0.20.23 milestone Sep 19, 2023
@tilacog tilacog force-pushed the tiago/allocaitons-cli-fixes branch from 9d9b041 to cb96035 Compare September 19, 2023 19:23
@tilacog
Copy link
Contributor Author

tilacog commented Sep 19, 2023

This is blocked due to type errors coming from common-ts v2.0.5.

@tilacog tilacog force-pushed the tiago/allocaitons-cli-fixes branch from 8991c6c to 24465b6 Compare September 21, 2023 17:19
@tilacog tilacog marked this pull request as ready for review September 21, 2023 17:38
@tilacog tilacog merged commit 9fb85ff into ford/allocations-cli-fixes Sep 21, 2023
@tilacog tilacog deleted the tiago/allocaitons-cli-fixes branch September 21, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚗 Merged
Development

Successfully merging this pull request may close these issues.

Remove AllocationExchange.claimMany()
1 participant