Agent: warn and wait if subgraph is behind the chain head #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilacog
force-pushed
the
662-indexer-agent-warn-and-wait-if-subgraph-is-behind
branch
8 times, most recently
from
fd45a0c to
fe25da4
Compare
|
CI results differ between the two previous runs: failed tests in one run have passed in the other. Also, tests passed locally. |
tilacog
force-pushed
the
662-indexer-agent-warn-and-wait-if-subgraph-is-behind
branch
from
fe25da4 to
10a55a8
Compare
tilacog
force-pushed
the
662-indexer-agent-warn-and-wait-if-subgraph-is-behind
branch
from
10a55a8 to
16a202d
Compare
|
Rebased on top of latest |
hopeyen
reviewed
Sep 26, 2023
fordN
reviewed
Sep 28, 2023
fordN
reviewed
Sep 28, 2023
fordN
approved these changes
Sep 28, 2023
tilacog
deleted the
662-indexer-agent-warn-and-wait-if-subgraph-is-behind
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new class,
SubgraphFreshnessChecker, designed to continuously retry subgraph queries if the subgraph is significantly behind the latest block in the blockchain. When such a condition is met, a warning will indicate the incident alongside the current block distance from the chain head.Configuration options have been extended both in network specification files and CLI parameters:
maxBlockDistance: Defines the threshold for subgraph freshness by measuring the distance between the latest indexed block in the subgraph and the most recent block on the network.freshnessSleepMilliseconds: Specifies the duration to wait before reattempting the query.After monitoring the testnet indexer block distances for an hour, we observed that the block distances for Arbitrum-Goerli typically fall below the 50-block threshold. No such distances were noted in Goerli. Consequently, we have set the default values for
maxBlockDistanceto0blocks andfreshnessSleepMillisecondsto5000.If the Agent or Service utilizes these default settings while operating on Arbitrum networks, a warning will be emitted to inform the user of the potential risk that queries may never be considered fresh.