Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax network subgraph validation in Indexer Service startup #759

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Relax network subgraph validation in Indexer Service startup #759

merged 1 commit into from
Sep 1, 2023

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented Aug 30, 2023

Emit warnings instead of throwing an error, which is causing the process to exit.

@tilacog tilacog requested review from fordN and hopeyen August 30, 2023 21:43
hopeyen
hopeyen approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@hopeyen hopeyen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 , even though arguably indexers can receive this error and find out what happened. If it is not working then they could just remove the configuration

@tilacog tilacog merged commit a285b05 into main Sep 1, 2023
8 checks passed
@tilacog tilacog deleted the tiago/network-sg-validation-warnings branch September 1, 2023 18:42
@tilacog tilacog added this to the v0.20.23 milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopeyen hopeyen hopeyen approved these changes

@fordN fordN Awaiting requested review from fordN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.20.23
Development

Successfully merging this pull request may close these issues.
2 participants
@tilacog @hopeyen