Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a protocolNetwork field to Rules, Actions, POI Disputes and Allocations #659

Closed
wants to merge 43 commits into from

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented May 12, 2023

Built on top of #654.
Resolves #650 , resolves #651

This PR refactors changes from #654, most notably the input validation.
Reviewing this PR instead of #654 for the latest refactorings is advised.

Adds a protocolNetworkfield to multiple types across packages:

  • IndexingRule
  • POIDispute
  • Action
  • Allocation

Updates cover:

  • database: a new migration:
    • introduces the new protocolNetwork,
    • populates it with the value of the configured network identifier column, and
    • alters primary keys of the IndexingRules and POIDispute tables
  • Indexer Management GraphQL API has new identifier types to accommodate the composite primary keys.
  • CLI, which now requires a mandatory --network option for most of its subcommand.

Changes not introduced in this PR:
Although affected components now have a protocolNetwork value, the program has no awareness of network multiplicity. #652 will address this issue.

And reorganize parsers in different modules,so that implementation
details stay separate from the module's interface (validators).
Also added some tests while debugging.
@tilacog tilacog marked this pull request as ready for review May 12, 2023 21:36
@tilacog tilacog mentioned this pull request May 12, 2023
@tilacog
Copy link
Contributor Author

tilacog commented Aug 25, 2023

Closing in favor of #668

@tilacog tilacog closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a protocolNetwork column to Rules and Actions table Refactor configuration
1 participant