-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a protocolNetwork
field to Rules, Actions, POI Disputes and Allocations
#659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And reorganize parsers in different modules,so that implementation details stay separate from the module's interface (validators).
Also added some tests while debugging.
The new type field's matches the database primary keys.
Closed
Closing in favor of #668 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #654.
Resolves #650 , resolves #651
Adds a
protocolNetwork
field to multiple types across packages:IndexingRule
POIDispute
Action
Allocation
Updates cover:
protocolNetwork
,IndexingRules
andPOIDispute
tables--network
option for most of its subcommand.Changes not introduced in this PR:
Although affected components now have a
protocolNetwork
value, the program has no awareness of network multiplicity. #652 will address this issue.