Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exchanged GNN with Model in the checks and in the type hint #744

Merged
merged 1 commit into from
Sep 10, 2024
Merged

exchanged GNN with Model in the checks and in the type hint #744

merged 1 commit into from
Sep 10, 2024

Conversation

niklasmei
Copy link
Collaborator

this pull request closes the issue #743

@RasmusOrsoe RasmusOrsoe self-requested a review September 10, 2024 08:46
RasmusOrsoe
RasmusOrsoe approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@niklasmei niklasmei merged commit dc7fa4f into graphnet-team:main Sep 10, 2024
14 checks passed
@niklasmei niklasmei deleted the actually_fix branch September 10, 2024 08:49
@RasmusOrsoe RasmusOrsoe mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusOrsoe RasmusOrsoe RasmusOrsoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niklasmei @RasmusOrsoe