Refactored model and standardmodel #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusOrsoe
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Hey @AMHermansen!
Thank you for this! I think the refactor looks good, but it also appears that you have removed the functionality introduced in #610 . Was this intentional?
| def forward( | ||
| self, data: Union[Data, List[Data]] | ||
| ) -> List[Union[Tensor, Data]]: | ||
| def forward(self, data: Data) -> List[Union[Tensor, Data]]: |
There was a problem hiding this comment.
Looks like you've removed the functionality introduced in #610. Was this intentional? If so, could you elaborate on why?
There was a problem hiding this comment.
@RasmusOrsoe Good catch, it would seem I was doing the refactor from an outdated branch prior to #610 . I've now added the functionality from #610 to the refactor.
Updates _get_batch_size to get batch_size from sequence bucketing.
RasmusOrsoe
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #599