-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redefinition of Tito model #611
Merged
ArturoLlorente
merged 12 commits into
graphnet-team:main
from
ArturoLlorente:update_tito_gnn
Oct 24, 2023
Merged
Redefinition of Tito model #611
ArturoLlorente
merged 12 commits into
graphnet-team:main
from
ArturoLlorente:update_tito_gnn
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Tito solution can be replicated with this class. Small changes in the training example to fit new input variables
@ArturoLlorente The IceTray disk space error is now fixed in main. Please try to update the branch and see if this doesn't fix the error. |
Merged
…path) and where to save the checkpoints during training (ckpt_save_path)
@ArturoLlorente Could you try to merge main into this branch again? Hopefully the workflows should work fine now. |
RasmusOrsoe
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes to have a more general GNN definition. All models used in the Tito solution can be replicated with this class. Previous version was only covering one especific case.
Small changes in the training example to fit new input variables.