Unit tests for Examples #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMHermansen
approved these changes
Sep 29, 2023
| @@ -90,7 +99,7 @@ def main_icecube_upgrade(backend: str) -> None: | |||
| "detector", choices=["icecube-86", "icecube-upgrade"] | |||
| ) | |||
|
|
|||
| args = parser.parse_args() | |||
| args, unknown = parser.parse_known_args() | |||
There was a problem hiding this comment.
Any reason why you've changed to use parse_known_args instead of parse_args?
| @@ -85,7 +95,7 @@ def load_data() -> None: | |||
| """ | |||
| ) | |||
|
|
|||
| args = parser.parse_args() | |||
| args, unknown = parser.parse_known_args() | |||
| @@ -83,7 +93,7 @@ def main() -> None: | |||
| """ | |||
| ) | |||
|
|
|||
| args = parser.parse_args() | |||
| args, unknown = parser.parse_known_args() | |||
| @@ -116,7 +126,7 @@ def main() -> None: | |||
| """ | |||
| ) | |||
|
|
|||
| args = parser.parse_args() | |||
| args, unknown = parser.parse_known_args() | |||
Thanks! Yes. Without it, the unit tests won't run. I found that when you run |
RasmusOrsoe
added a commit
to RasmusOrsoe/graphnet
that referenced
this pull request
Oct 25, 2023
Unit tests for Examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for all examples except for
05_pisa.This is now how unit tests are run.
IceTray-build:
Ubuntu-build:
MacOS:
I removed the example unit tests from the MacOS-build because it takes 30 minutes to complete.
Two examples turned out to be broken:
train_titoandtrain_multiclassifier. I fixed the multiclassification example and created an issue for the other. See #606.closes #594