Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in edge definition #590

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix typo in edge definition #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/graphnet/models/graphs/graph_definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def __init__(

# Member Variables
self._detector = detector
self._edge_definiton = edge_definition
self._edge_definition = edge_definition
self._node_definition = node_definition
if node_feature_names is None:
# Assume all features in Detector is used.
Expand Down Expand Up @@ -113,8 +113,8 @@ def forward( # type: ignore
graph.n_pulses = torch.tensor(len(node_features), dtype=torch.int32)

# Assign edges
if self._edge_definiton is not None:
graph = self._edge_definiton(graph)
if self._edge_definition is not None:
graph = self._edge_definition(graph)
else:
self.warnonce(
"No EdgeDefinition provided. Graphs will not have edges defined!"
Expand Down Expand Up @@ -154,7 +154,6 @@ def forward( # type: ignore
def _validate_input(
self, node_features: np.array, node_feature_names: List[str]
) -> None:

# node feature matrix dimension check
assert node_features.shape[1] == len(node_feature_names)

Expand Down