Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic attribute length adjustment #584

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

RasmusOrsoe
Copy link
Collaborator

This small PR removes the need for arguments index_column and node_level to model.predict_as_dataframe by replacing the if-else statements with an automated check that is able to adjust attribute sequence length to match the prediction lengths.

With this change, model.predict_as_dataframe is able to automatically adjust the length of all additional attributes for both node-level and graph-level predictions.

Copy link
Collaborator

@AMHermansen AMHermansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@RasmusOrsoe RasmusOrsoe merged commit 75e925f into graphnet-team:main Sep 11, 2023
12 checks passed
RasmusOrsoe added a commit to RasmusOrsoe/graphnet that referenced this pull request Oct 25, 2023
…-paths

automatic attribute length adjustment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants