Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/native #108

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Dev/native #108

merged 2 commits into from
Oct 18, 2023

Conversation

lmeyerov
Copy link
Contributor

@lmeyerov lmeyerov commented Oct 18, 2023 •
edited
Loading

Infra

  • Enable native execution with stronger default env var handling: VIEW_PATH env var and handle when LOG_LEVEL unavailable

Docs

  • Experimental native execution instructions

@lmeyerov lmeyerov requested a review from DataBoyTX October 18, 2023 16:45
DataBoyTX
DataBoyTX approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@DataBoyTX DataBoyTX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did not test myself, let me know if I should test on windows.

@lmeyerov
Copy link
Contributor Author

That'd be appreciated, but no reason to block current PR

@lmeyerov lmeyerov merged commit bda490a into master Oct 18, 2023
@lmeyerov lmeyerov deleted the dev/native branch October 18, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DataBoyTX DataBoyTX DataBoyTX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmeyerov @DataBoyTX