Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
benjie authored Nov 4, 2024
1 parent 062042e commit e81a9f9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion utils/website/graphile-export/how-it-works.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ code out, and now it can see the value of that "invisible" `a=7`:
[ 7 ]
```

Thus everything that can have these kinds of hidden properties must be wrapped
Thus everything that can reference values from a parent scope must be wrapped
in an `EXPORTABLE` call. Sometimes the inputs to the `EXPORTABLE` call
themselves also have to be wrapped in an `EXPORTABLE` call. You'll figure out
which things need wrapping by looking at the exported code and seeing where
Expand Down
4 changes: 2 additions & 2 deletions utils/website/graphile-export/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ The key reason to export your schema is to move schema introspection of postgres
from runtime to build time. This results in:

- Faster startup time
- Reduced thundering herd on the database in the event of an outage
- Much faster cold starts for Lambda
- Reduced thundering herd in the event of mass server restarts
- Much faster cold starts for serverless environments such as AWS Lambda
- And probably more

Previously, in Postgraphile 4, export took the form of encoding the Postgres
Expand Down

0 comments on commit e81a9f9

Please sign in to comment.