Add missing 'get_number_of_citations' method #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #859 +/- ##
==========================================
- Coverage 41.9% 41.9% -0.01%
==========================================
Files 1066 1066
Lines 144866 144870 +4
==========================================
+ Hits 60711 60712 +1
- Misses 84155 84158 +3
Continue to review full report at Codecov.
|
SNoiraud
pushed a commit
to SNoiraud/gramps
that referenced
this pull request
May 26, 2020
* Add missing 'get_number_of_citations' method * update db test for bsddb * fix trailing whitespace * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a cryptic issue (can reproduce it via etree gramplet or calling self.db.get_number_of_citations() without db loaded).
The method for citation objects seems missing and it returns a "NotImplementedError"
on some specific cases. I suppose it can raise an error too if number of citations is 0
after changes on db status but I cannot provide a proper testcase for this hypothesis.
So, just use the same method as the others primary objects on dummydb module.
See #857 and more details on addons.
Also missing on gramps50 and gramps51 branches.