-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WWII draft registration fields #312
base: master
Are you sure you want to change the base?
Conversation
added missing fields & corrected a few others.
This Form need a complete re-wright. When I created this form I was under the impression that there was only 1 card. There were 6 cards. The form need to be rewritten in a nondestructive manure. |
@Caulley Could you provide a full link to the form? Thanks. |
I am confused by this change. First, it is against master branch. It should be against gramps52. Second, the differences in the PR includes one field Place of employment or business (Address), so breaks existing forms. BUT this change is not consistent with gramps52 branch. gramps52 has the (Address) portion of the field name. Third, when I use the form provided in the previous Comment, it appears to not break existing form entries. So that specific form change seems okay. What I see is some additional fields (citizenship, occupation, ...) . I don't have any real examples using these new fields, so I cannot confirm that the update matches all of the WW2 DRC forms. All of my examples use the simple form that is in the original Form layout. I think this PR needs to be closed and reopened against gramps52 and use the form_us.xml which would include the revised WW2DRC portion. Then we can test it for merging. |
Examples of the draft cards can be found here - https://drive.google.com/drive/folders/1h2h23yhgT6V1Do6vqcGMqr2FvcoA0KA7?usp=drive_link |
added missing fields & corrected a few others.