-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MediaReport]: New image DPI option #285
base: maintenance/gramps51
Are you sure you want to change the base?
[MediaReport]: New image DPI option #285
Conversation
I tried to test this from CLI on Windows and got the following, what am I doing wrong? (my idea is to be able to generate reports from a script file) |
@lordemannd The report does not work for CLI in the current state, because it's using dialog windows which require a GUI. |
The report is coded as if can run in CLI mode (in the .gpr.py file), but the original author did not take that into account when he created the dialogs; he assumes that they will be run in GUI mode. The dialogs should be using some user type agnostic code, that would work equally well in GUI or CLI mode. |
A little more testing: Books: I added the Book report mode to media_report.gpr.py By this 1 line change, the book report seems working and was able to produce a pdf with MediaReport for 3 separate images. |
The dialogs in question occur after the initial options dialog; they occur during actual processing. So yes, it will appear to work unless you actually run the report. |
@lordemannd I updated the report and it should no longer rely on the Gramps GUI window when in CLI. Please test if it is working now. I have to fix more of my report and tool addons also using dialogs, since I only test in GUI mode and didn't thought enough about CLI related issues. I also didn't knew I forgot to add the |
@Mattkmmr, oops I guess I didn't see your change in Sep 2021, I will take a look now at your recent changes. |
@Mattkmmr, sorry for the delay, I have left some notes on bug report 11492. |
A possible solution to fix issue #11492. It requires #1007. A more detailed description can be found there.