This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 319
Fix: MediaPlaylist with discontinuities should not ignore maps #154
Open
vish91
wants to merge
35
commits into
grafov:master
Choose a base branch
from
zencoder:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: MediaPlaylist with discontinuities should not ignore maps
2 similar comments
* support custom tag decode/encode * add unit tests * go fmt * add go.mod * add writer tests, breakup custom interface * update readme * add comments to exports * parse custom tags first * update CustomDecoder.Segment to CustomDecoder.SegmentTag * Add badge of godoc.org for the awesome-go * Fix formatting with gofmt Also copyrights updated. Refs to issue grafov#151. * Fix comments by golint recommendations Refs to issue grafov#151. * Simplify with gofmt Refs to issue grafov#151. * Fix comments accordingly with golint advices Refs to issue grafov#151. * Integrate with deepsource.io It bring us more code quality analyzers. Refs grafov#151. * Add deepsource.io badge Refs grafov#151. * Add awesome-go badge Refs to issue grafov#151. * Try vanity import to work w/ travis * remove coveralls from fork Co-authored-by: Matthew Neil <[email protected]> Co-authored-by: Lei Gao <[email protected]> Co-authored-by: Alexander I.Grafov <[email protected]>
add id to m3u8 key
[Deliver-2341] Add new fields for Image Playlist
Co-authored-by: whitesource-for-github-com[bot] <50673670+whitesource-for-github-com[bot]@users.noreply.github.com>
* Support for EXT-X-CUE-OUT and EXT-X-CUE-IN tags * Support empty segments and unit tests * Remove old unit test * Error handling
NT map byterange
Add option to encode MAP tag before KEY tag
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaPlaylist with discontinuities should not ignore segment maps
https://tools.ietf.org/html/draft-pantos-http-live-streaming-23#section-4.3.2.5
https://developer.apple.com/documentation/http_live_streaming/hls_authoring_specification_for_apple_devices 8.20
MediaPlaylist with default Map and discontinuities should always have segment Maps, referring to the media initialization section after it ( be it content or ads or even if it is same as the DefaultMap )
Example:
today we get
instead we should expect: