irc-color fixed, less output, t.co url expander #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @matschundbrei, I don't linke the urlExtender - rest looks good to me |
|
Has to be specifically enabled via the HUBOT_TWITTER_TIMELINE_EXPAND_URL enviroment variable. Thanks for consideration. Cheers, |
|
Hi, I've refactored the silly external urlexpander from last time to a version that's only using information from the twitter-stream. Also: bumped versions across the board (it's been over a year) |
|
Sorry for opening that second pr, have now everything in this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I know it's not very nice to change three things at once, but I happen to just have done this.
Cheers,
M