-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Metrics()
to HTTP an GRPC proxies
#274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roobre
force-pushed
the
http-proxy-refactor
branch
from
August 2, 2023 21:22
bc492c1
to
4c63bff
Compare
roobre
force-pushed
the
http-proxy-refactor
branch
2 times, most recently
from
August 5, 2023 17:57
d42d0b5
to
0517bd8
Compare
roobre
commented
Aug 17, 2023
roobre
force-pushed
the
proxy-metrics
branch
3 times, most recently
from
August 17, 2023 14:53
385151c
to
a77e949
Compare
roobre
changed the title
Add
Add Aug 17, 2023
Metrics()
to Proxy interfaceMetrics()
to HTTP an GRPC proxies
pablochacin
reviewed
Aug 18, 2023
metrics: add MetricMap as a helper to work with metrics
pablochacin
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
Metrics
method to the Proxy interface. The main motivation for this is provide proxies a way to keep track of and record the number of requests they handle, which then can be used to aid in troubleshooting functionality such as #223.The newly added method is very slim and proxy implementations that do not support metrics can simply return
nil
.Checklist:
make lint
) and all checks pass.make test
) and all tests pass.make e2e-xxx
foragent
,disruptors
,kubernetes
orcluster
related changes)