Plugin E2E: Use custom data source for internal tests #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
added
the
no-changelog
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
sunker
force-pushed
the
plugin-e2e/replace-internal-datasources
branch
2 times, most recently
from
85938c1 to
d6017e9
Compare
sunker
force-pushed
the
plugin-e2e/replace-internal-datasources
branch
from
d6017e9 to
2fe4d97
Compare
sunker
force-pushed
the
plugin-e2e/replace-internal-datasources
branch
3 times, most recently
from
d9260b5 to
d84d360
Compare
sunker
force-pushed
the
plugin-e2e/replace-internal-datasources
branch
from
d84d360 to
b098538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR replaces the usage of the Google sheets ds and the Redshift ds in the internal test suite with a custom datasource . This has several benefits (see related issue). The tests are mostly a 1-1 conversation, but in a few situations they had to be rewritten from scratch. Also tried to cleanup internal test suite structure, improve playwright CI and add a new project to run tests against wide screens (UI may differ for wide screens, potentially breaking plugin-e2e APIs).
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/grafana-community-team/issues/270
Special notes for your reviewer: