Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ring for ingest-limits-frontend #15985

Merged
merged 15 commits into from
Jan 30, 2025
Merged

feat: add ring for ingest-limits-frontend #15985

merged 15 commits into from
Jan 30, 2025

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Jan 28, 2025 •
edited
Loading

What this PR does / why we need it:

This pull request adds a ring for the ingest-limits-frontend so it can be discovered and gRPC requests can be load balanced from distributors.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner January 28, 2025 16:54
@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-ring-ingest-limits-frontend branch from 629aed0 to 9a59704 Compare January 28, 2025 16:57
periklis
periklis reviewed Jan 28, 2025
View reviewed changes
pkg/limits/frontend/config.go Show resolved Hide resolved
pkg/limits/frontend/frontend.go Show resolved Hide resolved
pkg/loki/loki.go Outdated Show resolved Hide resolved
@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-ring-ingest-limits-frontend branch from 9a59704 to c829cf1 Compare January 28, 2025 17:14
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 28, 2025
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

💻 Deploy preview deleted.

@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-ring-ingest-limits-frontend branch from f0430ea to 27b80c4 Compare January 30, 2025 11:06
@grobinson-grafana grobinson-grafana merged commit 8cf347b into feat/usage-tracker Jan 30, 2025
126 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/add-ring-ingest-limits-frontend branch January 30, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis approved these changes

Assignees
No one assigned
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grobinson-grafana @periklis