fix: secretAccessKey has no length constraints #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.aws.amazon.com/IAM/latest/APIReference/API_AccessKey.html AccessKeyId has: Minimum length of 16. Maximum length of 128. SecretAccessKey has none
egor-romanov
requested review from
codebien and
olegbespalov
and removed request for
a team
|
|
|
Hey, @egor-romanov 👋🏻 Nice to see you here 🙇🏻 I think this check is something we mimicked from the node SDK at the time of the implementation, but after doing a bit more research about it, it looks like it's not indeed a strict requirement from the specification perspective 👍🏻 Could you also make a pass on the tests and confirm we do not have a test that tries to match that in one way or another? Finally, could you also sign the CLA to make merging possible? |
|
heyy! sure thing, will do 👍🙌 |
olegbespalov
approved these changes
Apr 2, 2024
oleiade
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secretAccessKey has no length constraints which currently may break things with non AWS S3 compatible services
Check for more info:
https://docs.aws.amazon.com/IAM/latest/APIReference/API_AccessKey.html