-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Workflow to automate release generation #89
Conversation
As we're at it, I thought of renaming the What do you think? |
I prepared that in the first pull request I prepared around this, but then I did care less because in this second approach the folder isn't being versioned at all. But yeah, it's a minor but fair change, that I can easily add in this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, after a discussion in treads, I think that maybe removing the build
directory for k6-jslib-aws
isn't a good thing (or perhaps it is too early to decide).
Also, I feel that the idea of porting the changes to the jslib.k6.io
isn't completely clear without a prototype (a PR to the jslib.k6.io
) that could demonstrate the new flow.
How about putting this PR on pause? I'll sketch up the PR with the routine automation I mentioned in #89 (comment), and we can continue the discussion.
Hey @olegbespalov, @oleiade, After our discussion, and as per what's commented in #89 (comment), I decided to update this pull request to just add the release workflow, so at least we can turn that step into a 1-click automation (it just requires creating the tag) and move on. Wdyt? |
In order to align this jslib with what was discussed (and consensuated) for k6-jslib-summary, and set up here, this pull request:- Removes thebuild
directory from control versioned files, in favor of automated releases- Sets up a GH Workflow to automate releases from Git tags push.- Updates the contribution guidelines accordingly.UPDATE (08/01)
It adds a new GitHub Workflow aiming the (future) automation of releases, heavily inspired by https://github.com/grafana/k6-jslib-summary/blob/main/.github/workflows/release.yml, but using Webpack & NPM instead of Yarn to adjust it to the project needs.
I left some comments in form of open questions inline.