Refactor client classes to make their properties private and readonly #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
requested review from
olegbespalov and
joanlopez
and removed request for
a team
olegbespalov
approved these changes
Nov 17, 2023
oleiade
force-pushed
the
refactor/private-readonly
branch
from
b83efab to
38e647c
Compare
|
Rebased on |
joanlopez
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was inspired by #76 and how @nickcaballero switched the
LambdaClientproperties asprivateand/orreadonly. This ensures that we only expose properties and/or let them be modified by users of the clients selectively.I thought this is a good practice to follow and aligned the codebase accordingly 🙇🏻