Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure GH workflow is run on push and PR #75

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Ensure GH workflow is run on push and PR #75

merged 3 commits into from
Nov 17, 2023

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Oct 31, 2023 •
edited
Loading

This PR updates the github workflow to ensure actions are ran on PRs, and brings minor improvements to the workflow itself.

@oleiade oleiade mentioned this pull request Nov 2, 2023
Closed
@oleiade oleiade marked this pull request as ready for review November 17, 2023 09:30
@oleiade oleiade requested a review from a team as a code owner November 17, 2023 09:30
@oleiade oleiade requested review from olegbespalov and joanlopez and removed request for a team November 17, 2023 09:30
@oleiade
Copy link
Member Author

oleiade commented Nov 17, 2023

I've updated the dependencies and also ran an npm audit fix to address some warnings raised by the action 🤝

@oleiade oleiade requested a review from olegbespalov November 17, 2023 11:28
olegbespalov
olegbespalov approved these changes Nov 17, 2023
View reviewed changes
Copy link

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@oleiade oleiade merged commit 7a52e6d into main Nov 17, 2023
2 checks passed
@oleiade oleiade deleted the ci/re-automate-test-runs branch November 17, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanlopez joanlopez joanlopez approved these changes

@olegbespalov olegbespalov olegbespalov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleiade @olegbespalov @joanlopez