-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to esbuild for building the library #116
Open
oleiade
wants to merge
6
commits into
main
Choose a base branch
from
esbuild
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
requested review from
mstoykov and
joanlopez
and removed request for
a team
September 6, 2024 14:46
Apologies for the noise, switching to draft as I caught issues in CI after the fact 👍🏻 |
joanlopez
reviewed
Sep 10, 2024
joanlopez
reviewed
Sep 10, 2024
I'm so confused, but TIL that if you delete a branch, even mistakenly, it automatically deletes the PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops webpack and switches to esbuild to build and bundle the library.
Here are a couple of reasons for that:
Apart from switching to build, the most notable change in this PR is that we configured it to use the ES modules format instead of CommonJS. The recent introduction of native ES Modules support in Sobek shouldn't pose any problem, but you never know.