Skip to content

Commit

Permalink
Fix unit test + cleanup (#106)
Browse files Browse the repository at this point in the history
* The unit test fix
  • Loading branch information
KOConchobhair authored Jun 17, 2024
1 parent f6b5dce commit ff8e6b6
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build and test the aws jslib against a Localstack instance
name: Lint the aws jslib
on:
# Enables running the workflow manually from the Actions tab
workflow_dispatch:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
node_modules/
/volume
dist/
.DS_Store
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/internal/signature.ts
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ export class SignatureV4 {
if (request.path) {
// Ensure there is a trailing slash at the end of the URL
// so that appending the path does not result in a malformed URL.
url = url.endsWith('/') ? url : url + '/'
url = url?.endsWith('/') ? url : url + '/'

// Append the path to the URL
url += request.path
Expand Down

0 comments on commit ff8e6b6

Please sign in to comment.