Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-distributed] Support initContainers and extraContainers for compactor #3391

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

loafoe
Copy link

@loafoe loafoe commented Nov 1, 2024

We have a use case where we need to run an init container and extra container as part of the compactor pod.

@CLAassistant
Copy link

CLAassistant commented Nov 1, 2024

CLA assistant check
All committers have signed the CLA.

@loafoe loafoe changed the title Support initContainers and extraContainers for compactor [tempo-distributed] Support initContainers and extraContainers for compactor Nov 1, 2024
@Sheikh-Abubaker
Copy link
Collaborator

Sheikh-Abubaker commented Nov 10, 2024

@zanhsieh this PR is based on the main branch, we should close it then right ?

@zanhsieh
Copy link
Collaborator

@Sheikh-Abubaker
I don't think it's a problem since it's on @loafoe 's fork main branch, not grafana repo main branch.

@loafoe
Copy link
Author

loafoe commented Nov 13, 2024

@zanhsieh @Sheikh-Abubaker I've rebased the PR to the latest main so it's clean merge again, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants