Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo] Add commonLabels (#3319) #3378

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/tempo-distributed/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: tempo-distributed
description: Grafana Tempo in MicroService mode
type: application
version: 1.20.0
version: 1.20.1
appVersion: 2.6.0
engine: gotpl
home: https://grafana.com/docs/tempo/latest/
Expand Down
1 change: 1 addition & 0 deletions charts/tempo-distributed/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,7 @@ The memcached default args are removed and should be provided manually. The sett
| gateway.topologySpreadConstraints | string | Defaults to allow skew no more then 1 node per AZ | topologySpread for gateway pods. Passed through `tpl` and, thus, to be configured as string |
| gateway.verboseLogging | bool | `true` | Enable logging of 2xx and 3xx HTTP requests |
| global.clusterDomain | string | `"cluster.local"` | configures cluster domain ("cluster.local" by default) |
| global.commonLabels | object | `{}` | Common labels for all object directly managed by this chart. scope: * |
| global.dnsNamespace | string | `"kube-system"` | configures DNS service namespace |
| global.dnsService | string | `"kube-dns"` | configures DNS service name |
| global.extraEnv | list | `[]` | Common environment variables to add to all pods directly managed by this chart. scope: admin-api, compactor, distributor, enterprise-federation-frontend, gateway, ingester, memcached, metrics-generator, querier, query-frontend, tokengen |
Expand Down
12 changes: 12 additions & 0 deletions charts/tempo-distributed/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,18 @@ app.kubernetes.io/part-of: memberlist
app.kubernetes.io/version: {{ .ctx.Chart.AppVersion | quote }}
{{- end }}
app.kubernetes.io/managed-by: {{ .ctx.Release.Service }}
{{ include "tempo.commonLabels" . }}
{{- end -}}

{{/*
Common Labels
Params:
ctx = . context
*/}}
{{- define "tempo.commonLabels" -}}
{{- with .ctx.Values.global.commonLabels }}
{{ toYaml . }}
{{- end }}
{{- end -}}

{{/*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ app.kubernetes.io/part-of: memberlist
app.kubernetes.io/version: {{ .ctx.Chart.AppVersion | quote }}
{{- end }}
app.kubernetes.io/managed-by: {{ .ctx.Release.Service }}
{{ include "tempo.commonLabels" . }}
{{- end -}}
{{/*
Resource name template
Expand Down
5 changes: 5 additions & 0 deletions charts/tempo-distributed/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ global:
# -- Common environment variables to add to all pods directly managed by this chart.
# scope: admin-api, compactor, distributor, enterprise-federation-frontend, gateway, ingester, memcached, metrics-generator, querier, query-frontend, tokengen
extraEnv: []

# -- Common labels for all object directly managed by this chart.
# scope: *
commonLabels: {}

fullnameOverride: ''
# fullnameOverride: tempo

Expand Down
2 changes: 1 addition & 1 deletion charts/tempo-vulture/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: tempo-vulture
description: Grafana Tempo Vulture - A tool to monitor Tempo performance.
type: application
version: 0.5.0
version: 0.5.1
appVersion: 2.5.0
engine: gotpl
home: https://grafana.com/docs/tempo/latest/
Expand Down
1 change: 1 addition & 0 deletions charts/tempo-vulture/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ tempoAddress:
| extraEnv | list | `[]` | Environment variables to add to the vulture pods |
| extraEnvFrom | list | `[]` | Environment variables from secrets or configmaps to add to the vulture pods |
| fullnameOverride | string | `""` | Overrides the chart's computed fullname |
| global.commonLabels | object | `{}` | Common labels for all object directly managed by this chart. scope: * |
| hostAliases | list | `[]` | hostAliases to add |
| image.pullPolicy | string | `"IfNotPresent"` | Docker image pull policy |
| image.repository | string | `"docker.io/grafana/tempo-vulture"` | Docker image repository |
Expand Down
3 changes: 3 additions & 0 deletions charts/tempo-vulture/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ helm.sh/chart: {{ include "tempo-vulture.chart" . }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
{{- end }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
{{- with .Values.global.commonLabels }}
{{ toYaml . }}
{{- end }}
{{- end }}

{{/*
Expand Down
5 changes: 5 additions & 0 deletions charts/tempo-vulture/values.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
global:
# -- Common labels for all object directly managed by this chart.
# scope: *
commonLabels: {}

# -- Overrides the chart's name
nameOverride: ""
# -- Overrides the chart's computed fullname
Expand Down
2 changes: 1 addition & 1 deletion charts/tempo/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: tempo
description: Grafana Tempo Single Binary Mode
type: application
version: 1.10.3
version: 1.10.1
appVersion: 2.5.0
engine: gotpl
home: https://grafana.net
Expand Down
1 change: 1 addition & 0 deletions charts/tempo/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Grafana Tempo Single Binary Mode
| extraLabels | object | `{}` | |
| extraVolumes | list | `[]` | Volumes to add |
| fullnameOverride | string | `""` | Overrides the chart's computed fullname |
| global.commonLabels | object | `{}` | Common labels for all object directly managed by this chart. |
| labels | object | `{}` | labels for tempo |
| nameOverride | string | `""` | Overrides the chart's name |
| networkPolicy.allowExternal | bool | `true` | |
Expand Down
3 changes: 3 additions & 0 deletions charts/tempo/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ app.kubernetes.io/managed-by: {{ .Release.Service }}
{{- with .Values.extraLabels }}
{{ toYaml . }}
{{- end }}
{{- with .Values.global.commonLabels }}
{{ toYaml . }}
{{- end }}
{{- end -}}

{{/*
Expand Down
5 changes: 5 additions & 0 deletions charts/tempo/values.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
global:
# -- Common labels for all object directly managed by this chart.
commonLabels: {}

# -- Overrides the chart's name
nameOverride: ""

Expand Down Expand Up @@ -282,6 +286,7 @@ podAnnotations: {}
podLabels: {}

# Apply extra labels to common labels.
# DEPRECATED: use global.commonLabels
extraLabels: {}

# -- Volumes to add
Expand Down
Loading