Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/CI: Detect incompatible changes #834

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

marefr
Copy link
Contributor

@marefr marefr commented Dec 7, 2023

What this PR does / why we need it:
Integrate gorelease in CI to highlight/detect incompatible changes. For now the idea is just to get a successful or failed workflow and highlight, maybe later we would like to set labels and such and/or require a certain label to be set to be able to merge etc.

Which issue(s) this PR fixes:
Fixes #78

Additonal info:
See https://github.com/grafana/grafana-plugin-sdk-go/actions/runs/7129862037/job/19414904707 for adding compatible changes
See https://github.com/grafana/grafana-plugin-sdk-go/actions/runs/7129905570/job/19415051117 for adding incompatible changes

@marefr marefr self-assigned this Dec 7, 2023
@marefr marefr marked this pull request as ready for review December 7, 2023 14:57
@marefr marefr requested a review from a team as a code owner December 7, 2023 14:57
@marefr marefr requested review from wbrowne, andresmgot and xnyo and removed request for a team December 7, 2023 14:57
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@marefr marefr merged commit c43fa75 into main Dec 7, 2023
@marefr marefr deleted the feat_78_detect_incompatible_changes branch December 7, 2023 15:07
@marefr
Copy link
Contributor Author

marefr commented Dec 7, 2023

Nice one!

Thanks @wbrowne 🙏

Aren't you out resting btw? 🤔

@wbrowne
Copy link
Member

wbrowne commented Dec 7, 2023

Nice one!

Thanks @wbrowne 🙏

Aren't you out resting btw? 🤔

homer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Build/CI: Integrate gorelease tool to identify/verify incompatible changes to highlight any breaking changes
2 participants