Refactor: Common opts structs and ResyncPeriod #1765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the first step towards refactoring the reconciliation loops for all CRs.
I've added a GrafanaCommonOptions struct which embeds the Common Options fields as a singular struct.
This means that all CRs will use the same comments, rules for CRD generation/deserialization, and default values.
This is especially apparent for
ResyncPeriod
which had a few different implementations.This does add the
AllowCrossNamespaceImport
toGrafanaNotificationPolicies
, but it is not handled in the Reconciliation loop as of now.It is recommended to review this one commit at a time.
Individual commits may not compile except for the final one.