Fix X-Id-Token auth header forwarding
#1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesoreyeram
reviewed
Oct 2, 2024
|
I have updated PR based on suggestions. Moreover, I had to update tests, but because they are in different package, Ihad to export those auth header names. |
yesoreyeram
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/grafana/support-escalations/issues/12471
We have recently changed X-Id-Token header from
X-ID-TokentoX-Id-Tokenand infinity was relying on the exactX-ID-Tokenvalue. This PR makes the check more robust, and checks for case insensitive form of header. This is the same function as in https://github.com/grafana/grafana-azure-sdk-go/blob/dc5d2b54c53f5ad1d8210508dfecf1775bd7fa1a/azusercontext/from_req.go#L67.More context in https://raintank-corp.slack.com/archives/C04CHPYT954/p1727793584704099
Fixed functionality:
infinityforward.mov