Schema: Generate query schema from go struct #232
+607
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
changed the title
ryantxu
requested review from
gabor,
yesoreyeram and
zoltanbedi
and removed request for
a team
ryantxu
commented
Mar 6, 2024
| err = builder.AddQueries(schemabuilder.QueryTypeInfo{ | ||
| Name: "default", | ||
| GoType: reflect.TypeOf(&QueryModel{}), | ||
| Examples: []data.QueryExample{ |
There was a problem hiding this comment.
any good example queries? Is there a public sheet we can stick some examples in that will always work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an easy example generating schema from go structs. See: grafana/grafana-plugin-sdk-go#897
This puts the results in
static/schema/query.types.json-- the structure and tooling for this folder is still TBD, but it does not hurt anything to merge before the whole pipeline exists (and also helps to have a basic real example living somewhere!)See also grafana/grafana#84032 (comment). (same question about utility of including the raw schemas)