Automate Docker images build & push #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
force-pushed
the
automate-image-publication
branch
from
d7958cb
to
1f381e3
Compare
codebien
reviewed
May 27, 2024
joanlopez
force-pushed
the
automate-image-publication
branch
from
1f381e3
to
ceeab88
Compare
joanlopez
force-pushed
the
automate-image-publication
branch
from
ceeab88
to
9a72ca4
Compare
joanlopez
commented
May 27, 2024
| @@ -13,7 +13,6 @@ RUN cd /etc/yum.repos.d/ \ | |||
|
|
|||
| RUN yum install -y \ | |||
| httpd \ | |||
| mod_auth_kerb \ | |||
There was a problem hiding this comment.
In theory with mod_auth_gssapi should be enough
👉🏻 https://projects.theforeman.org/issues/32352
joanlopez
commented
May 27, 2024
| @@ -17,7 +17,7 @@ RUN yum install -y \ | |||
|
|
|||
| ADD krb5-1.6.3.tar.gz /tmp | |||
| RUN cd /tmp/krb5-1.6.3/src && \ | |||
| ./configure && make && make install | |||
| ./configure && make CFLAGS="-fgnu89-inline" && make install | |||
There was a problem hiding this comment.
Fixes the inlining/duplication issue with recent versions of gcc compiler:
👉🏻 https://bugzilla.redhat.com/show_bug.cgi?id=547153
codebien
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to grafana/xk6-kerberos#35