Skip to content

Commit

Permalink
Review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
stevesg committed Jul 30, 2021
1 parent 7104443 commit 629d288
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@
* [ENHANCEMENT] Added a new tier (`medium_small_user`) so we have another tier between 100K and 1Mil active series. #364
* [ENHANCEMENT] Extend Alertmanager dashboard: #313
* "Tenants" stat panel - shows number of discovered tenant configurations.
* "Replication" row - information about the replication of tenants/alerts/silences over instances.
* "Tenant Configuration Sync" row - information about the configuration sync procedure.
* "Sharding Initial State Sync" row - information about the initial state sync procedure when sharding is enabled.
* "Sharding State Operations" row - information about various state operations which occur when sharding is enabled (replication, fetch, marge, persist).
* "Sharding Runtime State Sync" row - information about various state operations which occur when sharding is enabled (replication, fetch, marge, persist).
* [BUGFIX] Fixed `CortexIngesterHasNotShippedBlocks` alert false positive in case an ingester instance had ingested samples in the past, then no traffic was received for a long period and then it started receiving samples again. #308
* [BUGFIX] Alertmanager: fixed `--alertmanager.cluster.peers` CLI flag passed to alertmanager when HA is enabled. #329
* [BUGFIX] Fixed `CortexInconsistentRuntimeConfig` metric. #335
Expand Down
8 changes: 4 additions & 4 deletions cortex-mixin/dashboards/alertmanager.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -150,16 +150,16 @@ local utils = import 'mixin-utils/utils.libsonnet';
)
)
.addRow(
$.row('Sharding Runtime State Sync')
$.row('Sharding Initial State Sync')
.addPanel(
$.panel('Syncs/sec') +
$.panel('Initial syncs/sec') +
$.queryPanel(
'sum by(outcome) (rate(cortex_alertmanager_state_initial_sync_completed_total{%s}[$__rate_interval]))' % $.jobMatcher('alertmanager'),
'{{outcome}}'
)
)
.addPanel(
$.panel('Sync duration') +
$.panel('Initial sync duration') +
$.latencyPanel('cortex_alertmanager_state_initial_sync_duration_seconds', '{%s}' % $.jobMatcher('alertmanager'))
)
.addPanel(
Expand All @@ -178,7 +178,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
)
)
.addRow(
$.row('Sharding State Operations')
$.row('Sharding Runtime State Sync')
.addPanel(
$.panel('Replicate state to other alertmanagers /sec') +
$.queryPanel(
Expand Down

0 comments on commit 629d288

Please sign in to comment.