-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for IN operator as adhoc filter #986
Conversation
Thanks for the contribution! Make sure to sign the CLA and add a CHANGELOG entry. Could you also edit your PR description to include a screenshot or example adhoc value for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few notes/questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @Kenterfie!
Thanks for your fast reaction on that @aangelisc, but one question. I can find the change in the CHANGELOG.md, but can't find it in release 4.4.0? What happened to it? |
Hi @Kenterfie, apologies this looks like it didn't make it into the 4.4.0 release but was mistakenly included in the CHANGELOG. It'll be out in the next release. |
This merge request adds a missing feature, which we have actively used in the past with the Altinity Grafana datasource. In general it allows adhoc filters which make use of the IN operator.
This issue is also addressed in #883
Example adhoc filter
Expected additional filter
settings additional_table_filters={'table' : ' ipv4Dst IN (\'1.1.1.xxx\',\'2.2.2.xxx\')'}
Current additional filter output
settings additional_table_filters={'table' : ' ipv4Dst IN \'('1.1.1.xxx','2.2.2.xxx')\' '}