-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update Duration value in example traces dashboard #983
Conversation
Use the following command to run this PR with Docker at http://localhost:3000:
|
Just a note, division may not be the best operator here: Issue: #720 |
That's interesting @SpencerTorres, thank you for picking up on that. Would you suggest truncating the data to millisecond precision instead? |
I suppose it depends on how it's displayed, I want to avoid rounding to 0 and having that affect filtering |
I see, my understanding of the ClickHouse documentation is that |
I see the problem, I was previously using Either one works then, should be fine as long as it preserves the float value 👍 Thanks! |
Similar to #966 the duration displayed will now be the maximum value. I'm also explicitly using the
divide
function for readability.