Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource config, set OTel table names by default #973

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

SpencerTorres
Copy link
Collaborator

When creating a new datasource, the otel tables will now be set to otel_logs and otel_traces by default.
I see users get confused by this a lot, now they don't have to worry about setting the otel table names.

This does not affect existing datasources with tables already set. If the value is already set or an empty string, then the defaults will not be applied. Defaults will be applied only when the tables are undefined (such as when a new datasource is created).

default tables example

Changes:

  • added constants for default logs table and trace table
  • used those constants everywhere (placeholder text, config value, tests)
  • in the datasource config, otel tables will now be set to the default values
  • updated changelog

Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @SpencerTorres!

@aangelisc aangelisc merged commit 640270e into grafana:main Sep 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants