Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Labels" column for log queries #941

Merged
merged 14 commits into from
Sep 11, 2024
Merged

Conversation

SpencerTorres
Copy link
Collaborator

@SpencerTorres SpencerTorres commented Aug 14, 2024

Labels are an important feature for logging, not all details are in the log message. This PR adds a "Labels" column to the log query builder.

changes:

  • Added "Labels" column selector
  • Added quick filtering support to the logs panel for labels
  • Tests
  • Updated changelog

new column selector:
new column selector

labels are shown per line in logs panel
example labels

supports map filtering of labels using the buttons in the logs panel:
filter support

@kushmansingh
Copy link

Could a maintainer look at this please? It's a crucial feature for using OTEL logs

bossinc
bossinc previously approved these changes Aug 29, 2024
Copy link
Collaborator

@bossinc bossinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@bossinc bossinc enabled auto-merge (squash) August 30, 2024 21:11
auto-merge was automatically disabled September 6, 2024 02:54

Head branch was pushed to by a user without write access

aangelisc
aangelisc previously approved these changes Sep 6, 2024
@aangelisc
Copy link
Contributor

Hey @SpencerTorres, if you fix the merge conflicts we can get this in 😊

Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SpencerTorres!

@aangelisc aangelisc merged commit e25a879 into grafana:main Sep 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants